Skip to content

Add fix-whitespace, bump actions - #135

Open
philderbeast wants to merge 4 commits into
ucsd-progsys:mainfrom
up-do:ci/fix-whitespace
Open

Add fix-whitespace, bump actions#135
philderbeast wants to merge 4 commits into
ucsd-progsys:mainfrom
up-do:ci/fix-whitespace

Conversation

@philderbeast

@philderbeast philderbeast commented Jan 28, 2026

Copy link
Copy Markdown

Adds a whitespace action and fixes the issues fix-whitespace finds. Also bump other actions. The docs-ci-cd.yml action was failing with:

This request has been automatically failed because it uses a deprecated version of actions/upload-artifact: v3. Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

@ranjitjhala

Copy link
Copy Markdown
Member

Thank you!!!

@ranjitjhala

Copy link
Copy Markdown
Member

LGTM shall I merge?

@philderbeast

Copy link
Copy Markdown
Author

Yes please merge. I was a little worried about the html and pdf generation so ran the recipe from CI to generate those and am happy that there was no difference in the generated pdf and only whitespace differences in the html.

cp package.yaml.pandoc package.yaml
mkdir -p _site dist
nix-shell --pure --run hpack
nix-shell --pure --run "runghc ./Setup.hs configure --prefix=$PWD/out"
nix-shell --pure --run "runghc ./Setup.hs build && runghc ./Setup.hs install"
nix-shell --pure --run "make NO_STACK=y html"
nix-shell --pure --run "make NO_STACK=y pdf"
cp dist/pbook.pdf _site/book.pdf

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants